kevinrr888 opened a new pull request, #4852:
URL: https://github.com/apache/accumulo/pull/4852
closes #3505
_**Overview**_
- new class `BulkFileColData` to store the data needed to validate a
BulkFileColumn update
Changes to check():
- now uses switch instead of if
- validation logic of each column now done in separate methods
- removed unnecessary checks and simplified logic where applicable (e.g., if
checks that would never be true, same check done more than once)
- violations are no longer added to and returned by `validate` methods, only
added to. Avoids confusion with how the methods should be used.
- initialized violations at start as a list instead of dealing with
null. Null added extra unnecessary complexity.
Question:
- In this PR, I did not add any new check logic, only reorganized existing
code to avoid making the PR too complicated. If it is more clear now that more
checks need to be done, can add that in this PR or in follow on. As an example,
there is currently only validation of ServerColumnFamily.LOCK_QUAL and not
other qualifiers like ServerColumnFamily.TIME_QUAL,
ServerColumnFamily.FLUSH_QUAL, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
