DomGarguilo commented on PR #4850: URL: https://github.com/apache/accumulo/pull/4850#issuecomment-2329784720
Marking this as ready for review since I think its mostly done. One thing I thought of is if we want to use the description from the enum when registering the corresponding metric. For example: https://github.com/apache/accumulo/blob/3a265ed1fa98eee646d4a305c76374b699c274cf/server/tserver/src/main/java/org/apache/accumulo/tserver/BlockCacheMetrics.java#L57-L58 could be changed to ```java FunctionCounter.builder(BLOCKCACHE_INDEX_HITCOUNT.getName(), indexCache, getHitCount) .description(BLOCKCACHE_INDEX_HITCOUNT.getDescription()).register(registry); ``` this would make the description that appears in the docs the same as the one connected to the micrometer instrument. I am guessing we want to keep the description attached to the micrometer instrument more brief than the one that will appear on the docs but I figured I would ask. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
