cshannon opened a new pull request, #4866: URL: https://github.com/apache/accumulo/pull/4866
Update `ThriftScanner` to use nano time to be consistent with elapsed time tracking in other locations. Also, convert `timeOut` to be a Duration to prevent future errors. This value was being converted to seconds from millis which is error prone as there was not a good indication the unit was in seconds. This is a follow on to #4864 As a side note, there are plenty of other timeout related properties that are part of the scanner code. I started to convert those as well to Duration but it cascaded and started touching a lot of classes which i didn't think was a good idea for 2.1. However, I was thinking as part of 3.1 and 4.0 we may want to update some more fields in classes from a long to a Duration (assuming no performance concerns). Here are some examples I found but I am sure there are more spots: [TimeoutTabletLocator](https://github.com/apache/accumulo/blob/2a9aa76e97ac7b0359a7748f753313a992ebbb46/core/src/main/java/org/apache/accumulo/core/clientImpl/TimeoutTabletLocator.java#L42) (in 3.1 only) [ScannerOptions](https://github.com/apache/accumulo/blob/2a9aa76e97ac7b0359a7748f753313a992ebbb46/core/src/main/java/org/apache/accumulo/core/clientImpl/ScannerOptions.java#L56-L58) [TabletServerBatchReaderIterator](https://github.com/apache/accumulo/blob/c2e4874986157af720473af46d77030716e3009b/core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReaderIterator.java#L117) [ScanState](https://github.com/apache/accumulo/blob/c2e4874986157af720473af46d77030716e3009b/core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftScanner.java#L225) in `ThriftScanner` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
