keith-turner commented on PR #4867: URL: https://github.com/apache/accumulo/pull/4867#issuecomment-2339186481
> Did you see the mentioned memory issue actually happen or is this more preventative? Its a preventative change. The number of external compactions has the potential to scale with the number of tablets. A lot of the Accumulo code tries to avoid assuming that per tablet information fits in memory. This code is kinda doing that and its doing it per web request. > I am also wondering it would simplify the code if we used the memoizeWithExpiration in place of the other code that checks if an interval has passed before computing again (getScans(), getScanServerScans(), getCompactions(), getCompactorsInfo()). Although this should probably not be done in this PR. That would be good to investigate for a a follow on PR. Looking around in the monitor there is other code that also rate limits the amount of time data is fetched and that would be nice to use memoizeWithExpiration if its workable. Looking into this I noticed a REFRESH_TIME constant in the montior, I think I will use that for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
