keith-turner commented on code in PR #4872:
URL: https://github.com/apache/accumulo/pull/4872#discussion_r1757711896


##########
core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/ScanCacheProvider.java:
##########
@@ -30,42 +32,45 @@ public class ScanCacheProvider implements CacheProvider {
 
   public ScanCacheProvider(AccumuloConfiguration tableConfig, ScanDispatch 
dispatch,
       BlockCache indexCache, BlockCache dataCache) {
+
+    var loggingIndexCache = LoggingBlockCache.wrap(CacheType.INDEX, 
indexCache);
+    var loggingDataCache = LoggingBlockCache.wrap(CacheType.DATA, dataCache);

Review Comment:
   Inside the `LoggingBlockCache.wrap` method it checks if trace is enabled and 
if its not it just returns the cache w/o wrapping it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to