keith-turner commented on code in PR #4861:
URL: https://github.com/apache/accumulo/pull/4861#discussion_r1757792270
##########
server/base/src/main/java/org/apache/accumulo/server/manager/LiveTServerSet.java:
##########
@@ -228,15 +230,13 @@ public synchronized void scanServers() {
final Set<TServerInstance> updates = new HashSet<>();
final Set<TServerInstance> doomed = new HashSet<>();
- final String path = context.getZooKeeperRoot() + Constants.ZTSERVERS;
+ Set<ServiceLockPath> tservers =
+ context.getServerPaths().getTabletServer(Optional.empty(),
Optional.empty());
Review Comment:
Will this only return tservers that have a lock entry under them? If so
then that may impact the functionality in this class that cleans up tserver
nodes w/ no lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
