dlmarion commented on code in PR #4861:
URL: https://github.com/apache/accumulo/pull/4861#discussion_r1759173194
##########
server/base/src/main/java/org/apache/accumulo/server/manager/LiveTServerSet.java:
##########
@@ -227,16 +229,22 @@ public synchronized void scanServers() {
try {
final Set<TServerInstance> updates = new HashSet<>();
final Set<TServerInstance> doomed = new HashSet<>();
+ final ZooCache zc = getZooCache();
+ final String tserverRoot = context.getZooKeeperRoot() +
Constants.ZTSERVERS;
- final String path = context.getZooKeeperRoot() + Constants.ZTSERVERS;
+ Set<ServiceLockPath> tservers = new HashSet<>();
- HashSet<String> all = new HashSet<>(current.keySet());
- all.addAll(getZooCache().getChildren(path));
+ for (String resourceGroup : zc.getChildren(tserverRoot)) {
Review Comment:
Yeah, I can make that change. That will likely help to remove the residual
places in the code where the constants are being used and zookeeper paths being
accessed outside of ServerZooKeeperPaths. I'll plan on doing that for #4883 so
that I don't keep adding changes to this large PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
