DomGarguilo opened a new pull request, #4894:
URL: https://github.com/apache/accumulo/pull/4894
This PR uses Guavas `Suppliers.memoizeWithExpiration()` for caching,
replacing the manual caching logic. This allows us to:
* Remove `synchronized` from the get methods since
`Suppliers.memoizeWithExpiration()` is thread safe
* Remove the class-level maps that were previously being used for caching.
Now, the `fetch()` methods that update the data, directly return the data
instead of using these maps. These `fetch()` methods are called directly from
the suppliers now.
* Remove the age-off logic that was being done in the `fetch()` methods.
It should be noted that the functionality has slightly changed. Since we just
re-create a new map whenever the data is refreshed in the `fetch()` methods,
there are no old values that need to be aged off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
