keith-turner commented on code in PR #4897:
URL: https://github.com/apache/accumulo/pull/4897#discussion_r1764022099
##########
server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java:
##########
@@ -369,8 +369,7 @@ private void validateServerFamily(ArrayList<Short>
violations, ColumnUpdate colu
private void validateSuspendLocationFamily(ArrayList<Short> violations,
ColumnUpdate columnUpdate) {
String qualStr = new String(columnUpdate.getColumnQualifier(), UTF_8);
- String suspendColQualStr =
- new
String(SuspendLocationColumn.SUSPEND_COLUMN.getColumnQualifier().getBytes(),
UTF_8);
+ String suspendColQualStr =
SuspendLocationColumn.SUSPEND_COLUMN.getColumnQualifier().toString();
Review Comment:
We could make a constant for this String. For this case do not need to keep
recomputing the string. Could add that constant to the SuspendLocationColumn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
