ctubbsii commented on PR #4879: URL: https://github.com/apache/accumulo/pull/4879#issuecomment-2363446543
@keith-turner I updated the PR based on our discussion, in addition to a few small things (bump log4j2 version and use the annotation processor to generate the metadata for the registering the appender as a log4j plugin on the classpath; those changes make this ready for log4j 3, whenever that comes). I did test the config options, and they work, and properly reconfigure the appender if the file changes. I left the defaults commented out in the config file, to make it easier for users to modify. The main thing I'm uncertain about is the stopping of the executor, and whether that works well through reconfiguration.... it should, but it might need another pair of eyes to test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
