kevinrr888 opened a new pull request, #4912: URL: https://github.com/apache/accumulo/pull/4912
This PR addresses some follow on changes from https://github.com/apache/accumulo/pull/4524#issuecomment-2273932737: - [x] Add a toString() to FateKey - [x] Move MetaFateStore to org.apache.accumulo.core.fate.zookeeper - [x] Periodic clean up of dead reservations should be increased from every 30 seconds to every few minutes - [x] Add additional fate test case suggested in https://github.com/apache/accumulo/pull/4524#discussion_r1702301996 - From the new test case, discovered that verifyReserved() should also be checking if the tx has been deleted from the persisted store. This immediately prevents write ops from being attempted on deleted transactions. This caused UserFateStoreIT.delete() test to fail since delete() was called several times on the same tx store. Fixed this and cleaned up some code in the rest of this class (TestUserFateStore wasn't doing anything). A couple questions: - I noticed that required status checks are only present in UserFateStore not MetaFateStore. Should this be added to MetaFateStore? - With the increased time of the dead reservation cleanup, testDeadReservationsCleanup() now takes a lot longer (6 mins for me locally). Will this be an issue when the test runs on Jenkins? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
