cshannon commented on issue #4857: URL: https://github.com/apache/accumulo/issues/4857#issuecomment-2365151923
I'm going to open up a PR just for main for now and include the extra directory column validation check for two reasons. 1. The violation codes have diverged between [3.1](https://github.com/apache/accumulo/blob/2e63b7140d04fee881f429e674db0f96df4c6183/server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java#L239) vs [main](https://github.com/apache/accumulo/blob/f47f835c0be746bc32a52516fb0e89624574497c/server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java#L267). In 3.1 there are only 10 violation codes and we have 16 in main. If we want to add a new violation code to 3.1 for the directory check, we either have to make it number 11 and then go try and change codes 11-16 in main (which may be error prone to try and find all the spots), or we would need to just make it code 17 in 3.1 ad skip 11 through 16. I am not sure which is best because skipping the numbers is a lot easier but a bit weird to have missing codes. 2. I don't think the changes in 3.1 would merge forward cleanly anyways. The metadata constraints code has diverged a bit with the changes in elasticity so it's likely there would just be merge conflicts anyways in both the metadata constraints class and the test for it so I think it would probably be simpler to anyways to just backport the change and merge forward an empty commit if we decide it is worthwhile to do that. (and figure out how to handle the error code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
