ddanielr commented on code in PR #4899:
URL: https://github.com/apache/accumulo/pull/4899#discussion_r1771768248


##########
assemble/conf/log4j2.properties:
##########
@@ -33,6 +33,9 @@ appender.console.layout.pattern = 
%style{%d{ISO8601}}{dim,cyan} %style{[}{red}%s
 logger.shellaudit.name = org.apache.accumulo.shell.Shell.audit
 logger.shellaudit.level = warn
 
+logger.shell.name = org.apache.accumulo.shell.Shell

Review Comment:
   Older versions of the shell supported a `--debug` option that would modify 
the log output. 
   That flag has been deprecated in 2.x and no longer works. 
   
   Now users have to correctly identify the name of the shell logger by either 
referencing source code or by modifying the layout.pattern and then set the 
logging level to achieve the same result as the original `--debug` flag. 
   
   By adding the logger name in the log4j2 config, it reduces the level of 
effort needed for getting debug level logs. 
   
   The expectation is that adding this should not change the current logging 
behavior of the shell as it was already emitting info level logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to