keith-turner commented on code in PR #4980:
URL: https://github.com/apache/accumulo/pull/4980#discussion_r1806948062


##########
core/src/main/java/org/apache/accumulo/core/metrics/Metric.java:
##########
@@ -51,6 +51,17 @@ public enum Metric {
       MetricType.GAUGE, "Count of rejected jobs.", MetricCategory.COMPACTOR),
   
COMPACTOR_JOB_PRIORITY_QUEUE_JOBS_PRIORITY("accumulo.compactor.queue.jobs.priority",
       MetricType.GAUGE, "Lowest priority queued job.", 
MetricCategory.COMPACTOR),
+  
COMPACTOR_JOB_PRIORITY_QUEUE_JOBS_MIN_AGE("accumulo.compactor.queue.jobs.min.age",
+      MetricType.GAUGE, "Minimum age of currently queued jobs in seconds.",
+      MetricCategory.COMPACTOR),
+  
COMPACTOR_JOB_PRIORITY_QUEUE_JOBS_MAX_AGE("accumulo.compactor.queue.jobs.max.age",
+      MetricType.GAUGE, "Maximum age of currently queued jobs in seconds.",
+      MetricCategory.COMPACTOR),
+  
COMPACTOR_JOB_PRIORITY_QUEUE_JOBS_AVG_AGE("accumulo.compactor.queue.jobs.avg.age",
+      MetricType.GAUGE, "Average age of currently queued jobs in seconds.",
+      MetricCategory.COMPACTOR),
+  
COMPACTOR_JOB_PRIORITY_QUEUE_JOBS_POLL_TIMER("accumulo.compactor.queue.jobs.poll.time",
+      MetricType.TIMER, "Time for poll to return compaction jobs.", 
MetricCategory.COMPACTOR),

Review Comment:
   Thought of some possible alternative names for this metric 
`accumulo.compactor.queue.jobs.exit.time` or 
`accumulo.compactor.queue.jobs.exit.age` and the following description to go 
along with it.
   
   ```suggestion
         MetricType.TIMER, "Tracks time a job spent in the queue before exiting 
the queue.", MetricCategory.COMPACTOR),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to