keith-turner commented on code in PR #4992:
URL: https://github.com/apache/accumulo/pull/4992#discussion_r1806969239
##########
core/src/main/java/org/apache/accumulo/core/fate/user/UserFateStore.java:
##########
@@ -231,7 +228,9 @@ public Optional<FateTxStore<T>> tryReserve(FateId fateId) {
// Create a unique FateReservation for this reservation attempt
FateReservation reservation = FateReservation.from(lockID,
UUID.randomUUID());
- FateMutator.Status status =
newMutator(fateId).putReservedTx(reservation).tryMutate();
+ // requiring any status prevents creating an entry if the fate id doesn't
exist
+ FateMutator.Status status =
Review Comment:
Nice comment here. Interesting, I suppose the status check was not needed
previously because it was assumed the reservation column always existed if the
fate operation existed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
