dlmarion commented on code in PR #5035:
URL: https://github.com/apache/accumulo/pull/5035#discussion_r1831550295
##########
assemble/bin/accumulo-cluster:
##########
@@ -157,16 +161,33 @@ function control_service() {
# using the value of $host
#
if [[ $# -gt 3 ]]; then
- ACCUMULO_SERVICE_INSTANCE="${ACCUMULO_SERVICE_INSTANCE}"
"${bin}/accumulo-service" "$service" "$control_cmd" "-a" "$host" "${@:4}"
+ EXTRA_ARGS="${*:4}"
+ if [[ -n $DEBUG ]]; then
+ echo "ACCUMULO_SERVICE_INSTANCE=\"${ACCUMULO_SERVICE_INSTANCE}\"
\"${bin}/accumulo-service\" \"$service\" \"$control_cmd\" \"-a\" \"$host\"
$EXTRA_ARGS"
+ else
+ ACCUMULO_SERVICE_INSTANCE="${ACCUMULO_SERVICE_INSTANCE}"
"${bin}/accumulo-service" "$service" "$control_cmd" "-a" "$host" "$EXTRA_ARGS"
Review Comment:
shellcheck shows a warning with what I did in 24b3356, but it works. The
issue is that the `ACCUMULO_SERVICE_INSTANCE="${ACCUMULO_SERVICE_INSTANCE}"`
can't be enclosed in quotes when you execute the command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
