keith-turner commented on code in PR #5044:
URL: https://github.com/apache/accumulo/pull/5044#discussion_r1834559075


##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -338,11 +338,15 @@ private long loadFiles(TableId tableId, Path bulkDir, 
LoadMappingIterator loadMa
         
TabletsMetadata.builder(manager.getContext()).forTable(tableId).overlapping(startRow,
 null)
             .checkConsistency().fetch(PREV_ROW, LOCATION, LOADED, 
TIME).build()) {
 
+      // The tablet iterator and load mapping iterator are both iterating over 
data that is sorted
+      // in the same way. The two iterators are each independently advanced to 
find common points in
+      // the sorted data.

Review Comment:
   Re resorting, thinking validation would be better as resorting the data may 
hide a bug elsewhere in the code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to