ctubbsii commented on PR #5066:
URL: https://github.com/apache/accumulo/pull/5066#issuecomment-2479437830
Okay, so that does look like it's working then. As an aside, even though the
current yaml seems to be very robust in terms of configurability, I'm wondering
if the implementation would be simpler and the config file could be more
intuitive, if the config were organized primarily by groups and hosts, rather
than primarily by server types.
For example:
```yaml
groups:
- default:
hosts: [ localhost ]
manager: 1
monitor: 1
gc: 1
tserver: 1
compactor: 1
sserver: 1
- test1:
hosts: [ localhost ]
tserver: 2
- test2:
hosts: [ localhost ]
compactor: 3
- test3:
hosts: [ localhost ]
sserver: 4
```
So now, the script becomes simpler: for each group, set up the group options
(name, etc.), then for each host within that group, ssh, and for each service
within that group during that ssh session, start up the service.
None of this is strictly necessary for your PR, but I'm mentioning it here,
because I think it aligns your goal of making the scripts more efficient, by
using a config that represents a simpler and more efficient program flow (and
is also more intuitive).
One thing that could change from this suggestion, though, is instead of
having just a count, each type could be a complex object like:
```yaml
tserver:
count: 2
extra-opts: [ ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
