ddanielr commented on code in PR #5082:
URL: https://github.com/apache/accumulo/pull/5082#discussion_r1849323577
##########
server/base/src/main/java/org/apache/accumulo/server/conf/CheckCompactionConfig.java:
##########
@@ -106,7 +106,8 @@ public static void validate(AccumuloConfiguration config,
Level level)
Set<String> defaultService = Set.of(DEFAULT_COMPACTION_SERVICE_NAME);
if (servicesConfig.getPlanners().keySet().equals(defaultService)) {
- log.warn("Only the default compaction service was created - {}",
defaultService);
+ log.atLevel(level).log("Only the default compaction service was created
- {}",
Review Comment:
Iirc, the original goal of this log message was to alert users that the
compaction service might not have been properly created. However, if a custom
service was never defined than this just logs endlessly.
Might be a good follow on to try and validate the servicesConfig planners vs
what planner prefixes might be set in the properties? and only log if the
there's a difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
