keith-turner commented on code in PR #5099:
URL: https://github.com/apache/accumulo/pull/5099#discussion_r1855220498
##########
assemble/bin/accumulo-cluster:
##########
@@ -651,28 +639,46 @@ function main() {
fi
cat <<EOF >"$conf"/cluster.yaml
manager:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
+ hosts:
+ - localhost
monitor:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
+ hosts:
+ - localhost
gc:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
Review Comment:
Would be nice to document these options somehow in this file. Is this only
for accumulo sever process args? Assuming it can not contain jvm args? If so
could name it `server_args` which is a bit more specific. Could possibly have
a `jvm_args` in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
