dlmarion commented on code in PR #5114:
URL: https://github.com/apache/accumulo/pull/5114#discussion_r1858986813
##########
assemble/bin/accumulo-cluster:
##########
@@ -32,9 +32,9 @@ Commands:
stop Stops Accumulo cluster
kill Kills Accumulo cluster
start-non-tservers Deprecated. Starts all services except tservers
Review Comment:
I'm wondering if we should remove the deprecated commands at this point.
Were they marked deprecated in an older release?
##########
assemble/bin/accumulo-cluster:
##########
@@ -273,7 +273,12 @@ function stop_sservers() {
function start_tservers() {
echo "Starting tablet servers ..."
- for group in $TSERVER_GROUPS; do
+ groups=$TSERVER_GROUPS
+ if [[ -n $1 ]]; then
+ groups="$1"
+ echo "Only stopping servers for group: ${groups}"
Review Comment:
```suggestion
echo "Only starting servers for group: ${groups}"
```
##########
assemble/bin/accumulo-cluster:
##########
@@ -32,9 +32,9 @@ Commands:
stop Stops Accumulo cluster
kill Kills Accumulo cluster
start-non-tservers Deprecated. Starts all services except tservers
- start-servers [--all|--tservers|--no-tservers|--sservers
[group]|--compactors [group]]
+ start-servers [--all|--tservers [group]|--no-tservers|--sservers
[group]|--compactors [group]]
Review Comment:
I'm thinking we should either get rid of the `--no-tservers` option or add
`--no-sservers` and `--no-compactors`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
