DomGarguilo commented on code in PR #5112:
URL: https://github.com/apache/accumulo/pull/5112#discussion_r1859126639
##########
core/src/main/java/org/apache/accumulo/core/metrics/Metric.java:
##########
@@ -304,36 +308,49 @@ public String getDescription() {
return description;
}
- public MetricCategory getCategory() {
- return category;
+ public MetricDocSection getDocSection() {
+ return section;
}
public enum MetricType {
GAUGE, COUNTER, TIMER, LONG_TASK_TIMER, DISTRIBUTION_SUMMARY,
FUNCTION_COUNTER, CACHE
}
- public enum MetricCategory {
- GENERAL_SERVER("General Server Metrics"),
- COMPACTION("Compaction Metrics"),
- COMPACTOR("Compactor Metrics"),
- FATE("Fate Metrics"),
- GARBAGE_COLLECTION("Garbage Collection Metrics"),
- TABLET_SERVER("Tablet Server Metrics"),
- SCAN("Scan Metrics"),
- SCAN_SERVER("Scan Server Metrics"),
- THRIFT("Thrift Metrics"),
- BLOCK_CACHE("Block Cache Metrics"),
- MANAGER("Manager Metrics");
+ public enum MetricDocSection {
+ GENERAL_SERVER("General Server Metrics", "Metrics that are generated
across all server types."),
+ COMPACTION("Compaction Metrics",
+ "Metrics specific to compactions, both minor and major. Metrics for
major compactions"
+ + " will likely have a 'queue.id' tag. The CompactionCoordinator
component in the Manager creates a queue for each CompactionService"
+ + " in the configuration. The 'queue.id' tag may map directly to
the name of a Compactor resource group."),
+ COMPACTOR("Compactor Metrics", "Metrics that are generated by the
Compactor processes."),
+ FATE("Fate Metrics",
+ "Metrics that are generated by the Fate component in the Manager
process."),
+ GARBAGE_COLLECTION("Garbage Collection Metrics",
+ "Metrics that are generated by the Garbage Collector process"),
Review Comment:
```suggestion
"Metrics that are generated by the Garbage Collector process."),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
