cshannon commented on PR #5152: URL: https://github.com/apache/accumulo/pull/5152#issuecomment-2526170843
@dlmarion and @keith-turner - This fixes the failed test mentioned [here](https://github.com/apache/accumulo/pull/5102#issuecomment-2525192277) The cause was that with the refactoring to make everything multi-threaded all the validation was being done for each server in a new thread and the exception was being wrapped in ExecutionException and then caught and unwrapped and rethrown as AccumuloException. I could have fixed to the test to handle this but instead I thought it made a lot more sense to do a pre-validation before the thread pool was constructed and any RPC calls are made. The time it takes to iterate through even a few thousand servers just to check the type and fail fast before making any RPC calls is going to be trivial and it prevents the case where all the requests get made and eat up a bunch of resources when one of the servers are invalid which causes the whole thing to eventually fail anyways. Besides this new validation potentially saving resources, it also has the nice side effect of fixing the test failure as the IllegalArgumentException is now properly thrown again and not wrapped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
