dlmarion commented on code in PR #5164:
URL: https://github.com/apache/accumulo/pull/5164#discussion_r1880131329
##########
assemble/bin/accumulo-cluster:
##########
@@ -59,14 +59,15 @@ isDebug() {
}
debug() {
- isDebug && echo "${@@P}"
+ isDebug && echo "$1"
+
}
debugAndRun() {
- debug "$@"
+ # Use $* to convert all args as a single argument
+ debug "$*"
if ! isDebug; then
- # shellcheck disable=SC2294
- eval "${@@P}"
+ eval "$(printf "%q " "$@")"
Review Comment:
Yeah, I agree . `eval` was messing things up and unquoting things before
executing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
