keith-turner commented on code in PR #5170:
URL: https://github.com/apache/accumulo/pull/5170#discussion_r1885857426


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java:
##########
@@ -458,6 +458,26 @@ private void write(final Collection<CommitSession> 
sessions, boolean mincFinish,
       // the logs haven't changed.
       final int finalCurrent = currentLogId;
       if (!success) {
+
+        if (tserver.getLock() == null || 
!tserver.getLock().verifyLockAtSource()) {

Review Comment:
   There could be a lot of threads running this code for writes in lots of 
tserers.  If there is temporary HDFS hiccup across the clusterit could cause 
all of those threads to jump on zookeeper.  That is probably ok, so not sure we 
should try to do anything about that.  Might be worthwhile adding some debug or 
greater logging when this check is run so that its known that it is happening.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to