ctubbsii commented on code in PR #5192:
URL: https://github.com/apache/accumulo/pull/5192#discussion_r1901370846
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ZooCache.java:
##########
@@ -51,10 +53,13 @@
* A cache for values stored in ZooKeeper. Values are kept up to date as they
change.
*/
public class ZooCache {
+
+ public interface ZooCacheWatcher extends Consumer<WatchedEvent> {}
Review Comment:
I don't see a problem with the name ZCacheWatcher. It is a private class
internal to ZooCache, so its name doesn't matter. The better question is what
should this "external watcher" interface be called. We could just remove the
interface, and just make the API be an unnamed `Consumer<WatchedEvent>`. I
thought it might be easier to have a name, so we could have stronger type
checking, and find the implementations more easily in the code. I figured a
name associated with the class it was used exclusively with would make the most
sense, but we can rename it to anything else, if it makes more sense. I'll take
suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
