keith-turner commented on code in PR #5229:
URL: https://github.com/apache/accumulo/pull/5229#discussion_r1905907246
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/CompactionMetadata.java:
##########
@@ -93,10 +95,31 @@ public FateId getFateId() {
return fateId;
}
+ private static class InputFile {
+ String path;
+ String startRow;
+ String endRow;
+
+ private static InputFile from(StoredTabletFile stf) {
+ InputFile i = new InputFile();
+ i.path = stf.getPath().toString();
+ Range r = stf.getRange();
+ i.startRow = r.getStartKey() == null ? "null" :
r.getStartKey().toString();
Review Comment:
> path and range are defined in AbstractTabletFile. Can we just move the
serialization and deserialization methods, and TabletFileCqMetadataGson there
and make them public?
IMO it would be nice to avoid making them public. I was thinking some
package private methods like the follow could be added to StoredTabletFile in
addition to making TabletFileCqMetadataGson package private. Could refactor
the code in StoredTabletFile to accomodate and or use these methods.
```
static StoredTabletFile deserialize(TabletFileCqMetadataGson serialized) {
}
static TabletFileCqMetadataGson serialize(StoredTabletFile
storedTabletFile) {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
