keith-turner commented on code in PR #5231:
URL: https://github.com/apache/accumulo/pull/5231#discussion_r1906019351
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -294,6 +294,12 @@ public enum Property {
+ " user-implementations of pluggable Accumulo features, such as the
balancer"
+ " or volume chooser.",
"2.0.0"),
+ GENERAL_CACHE_MANAGER_IMPL("general.block.cache.manager.class",
+
"org.apache.accumulo.core.file.blockfile.cache.lru.LruBlockCacheManager",
PropertyType.STRING,
+ "Specifies the class name of the block cache factory implementation."
+ + " Alternative implementation is"
+ + "
org.apache.accumulo.core.file.blockfile.cache.tinylfu.TinyLfuBlockCacheManager.",
Review Comment:
Why change the default impl from LruBlockCacheManager to
TinyLfuBlockCacheManager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
