keith-turner commented on PR #5236:
URL: https://github.com/apache/accumulo/pull/5236#issuecomment-2578132706
Manually tested this using this following test.
```java
public class TmpIT extends AccumuloClusterHarness {
@Override
public void configureMiniCluster(MiniAccumuloConfigImpl cfg, Configuration
hadoopCoreSite) {
// cfg.setProperty(Property.TSERV_TOTAL_MUTATION_QUEUE_MAX, "10");
cfg.setProperty(Property.TSERV_UPDATE_SESSION_MAXIDLE, "10s");
}
@Test
public void testUnclosedUpdateSessionsions() throws Exception {
String table = getUniqueNames(1)[0];
try (AccumuloClient c =
Accumulo.newClient().from(getClientProps()).build()) {
c.tableOperations().create(table);
Random rand = new Random();
for (int i = 0; i < 100; i++) {
var ctx = (ClientContext) c;
var tableId = ctx.getTableId(table);
var extent = new KeyExtent(tableId, null, null);
var tabletMetadata = ctx.getAmple().readTablet(extent,
TabletMetadata.ColumnType.LOCATION);
var location = tabletMetadata.getLocation();
assertNotNull(location);
assertEquals(TabletMetadata.LocationType.CURRENT,
location.getType());
TabletClientService.Iface client =
ThriftUtil.getClient(ThriftClientTypes.TABLET_SERVER,
location.getHostAndPort(), ctx);
// Make the same RPC calls made by the BatchWriter, but pass a
corrupt serialized mutation
// in
// this try block.
try {
TInfo tinfo = TraceUtil.traceInfo();
long sessionId = client.startUpdate(tinfo, ctx.rpcCreds(),
TDurability.DEFAULT);
byte row[] = new byte[32];
int valSize = rand.nextInt(900)+100;
byte value[] = new byte[valSize];
rand.nextBytes(row);
rand.nextBytes(value);
client.applyUpdates(tinfo, sessionId, extent.toThrift(),
List.of(createTMutation(Base64.getEncoder().encodeToString(row),
Base64.getEncoder().encodeToString(value))));
// not closing update session, this will cause it to idle out on
the server side.
} finally {
ThriftUtil.returnClient((TServiceClient) client, ctx);
}
}
UtilWaitThread.sleep(60000);
}
}
}
```
and saw the following in the logs when enabling trace in the config. Those
are the last few lines of the cleanup, a lot more were printed.
```
TabletServer_436604017.out:2025-01-08T16:38:48,687
[tserver.TabletClientHandler] TRACE: cleaning up abandoned update session,
decrementing totalQueuedMutationSize by 698
TabletServer_436604017.out:2025-01-08T16:38:48,687 [tserver.TabletServer]
TRACE: totalQueuedMutationSize is now 4410 after adding -698
TabletServer_436604017.out:2025-01-08T16:38:48,687
[tserver.TabletClientHandler] TRACE: cleaning up abandoned update session,
decrementing totalQueuedMutationSize by 990
TabletServer_436604017.out:2025-01-08T16:38:48,687 [tserver.TabletServer]
TRACE: totalQueuedMutationSize is now 3420 after adding -990
TabletServer_436604017.out:2025-01-08T16:38:48,687
[tserver.TabletClientHandler] TRACE: cleaning up abandoned update session,
decrementing totalQueuedMutationSize by 374
TabletServer_436604017.out:2025-01-08T16:38:48,687 [tserver.TabletServer]
TRACE: totalQueuedMutationSize is now 3046 after adding -374
TabletServer_436604017.out:2025-01-08T16:38:48,687
[tserver.TabletClientHandler] TRACE: cleaning up abandoned update session,
decrementing totalQueuedMutationSize by 1166
TabletServer_436604017.out:2025-01-08T16:38:48,687 [tserver.TabletServer]
TRACE: totalQueuedMutationSize is now 1880 after adding -1166
TabletServer_436604017.out:2025-01-08T16:38:48,687
[tserver.TabletClientHandler] TRACE: cleaning up abandoned update session,
decrementing totalQueuedMutationSize by 662
TabletServer_436604017.out:2025-01-08T16:38:48,687 [tserver.TabletServer]
TRACE: totalQueuedMutationSize is now 1218 after adding -662
TabletServer_436604017.out:2025-01-08T16:38:48,687
[tserver.TabletClientHandler] TRACE: cleaning up abandoned update session,
decrementing totalQueuedMutationSize by 1218
TabletServer_436604017.out:2025-01-08T16:38:48,687 [tserver.TabletServer]
TRACE: totalQueuedMutationSize is now 0 after adding -1218
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
