dlmarion commented on code in PR #5240:
URL: https://github.com/apache/accumulo/pull/5240#discussion_r1909188061
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -292,26 +292,26 @@ public TabletFileCq(Path path, Range range) {
}
static class TabletFileCqMetadataGson {
- private String path;
- private byte[] startRow;
- private byte[] endRow;
+ protected String metadataEntry;
+ protected String path;
+ protected byte[] startRow;
+ protected byte[] endRow;
Review Comment:
So, it looks like `TabletFileCq` is just a single object to hold a Path and
Range, like `Pair<Path,Range>`. I think the metadata string is the correct
serialization of StoredTabletFile in all cases. I'm thinking that
`TabletFileCqMetadataGson` should be moved to `CompactionMetadata` as this is
providing a convenience for the external compaction json in the metadata only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
