keith-turner opened a new pull request, #5248:
URL: https://github.com/apache/accumulo/pull/5248

   Rfile.closeLocalityGroupReaders() was suppressing IOExceptions. This method 
was called by Rfile.closeDeepCopies() which is called by 
FileManager.releaseReaders().  Suppressing the exception meant that 
releaseReaders() did not see the exception and would decided to return the 
rfile to the pool when it should not.
   
   The only other code calling Rfile.closeLocalityGroupReaders() was 
Rfile.close(). Refactored the code so that Rfile.close() still suppressed the 
exception and Rfile.closeDeepCopies() does not suppress.  Tried to preserve the 
behavior that Rfile.close() closes as many of its underlying resource as 
possible even if some exceptions occur.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to