dlmarion commented on code in PR #5253:
URL: https://github.com/apache/accumulo/pull/5253#discussion_r1914763714
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java:
##########
@@ -247,7 +247,8 @@ public ClientContext(SingletonReservation reservation,
ClientInfo info,
this.singletonReservation = Objects.requireNonNull(reservation);
this.tableops = new TableOperationsImpl(this);
this.namespaceops = new NamespaceOperationsImpl(this, tableops);
- this.serverPaths = Suppliers.memoize(() -> new ServiceLockPaths(this));
+ this.serverPaths =
+ Suppliers.memoize(() -> new ServiceLockPaths(this.getZooKeeperRoot(),
this.getZooCache()));
Review Comment:
If the ClientContext is closed, is the ZooCache also closed?
##########
test/src/main/java/org/apache/accumulo/test/functional/ManagerAssignmentIT.java:
##########
@@ -92,6 +93,8 @@
public class ManagerAssignmentIT extends SharedMiniClusterBase {
+ private static AccumuloClient client;
Review Comment:
I think the diff below is large because of the variable name change from `c`
to`client`. I understand why you changed the name, but it's hard to see if
there are any other differences. I'm wondering if it makes sense to change the
variable name back to `c` to review, and then rename right before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
