keith-turner commented on code in PR #4898:
URL: https://github.com/apache/accumulo/pull/4898#discussion_r1920390043
##########
core/src/main/java/org/apache/accumulo/core/data/LoadPlan.java:
##########
@@ -228,4 +242,225 @@ public LoadPlan build() {
}
};
}
+
+ private static final TableId FAKE_ID = TableId.of("999");
+
+ private static class JsonDestination {
+ String fileName;
+ String startRow;
+ String endRow;
+ RangeType rangeType;
+
+ JsonDestination() {}
+
+ JsonDestination(Destination destination) {
+ fileName = destination.getFileName();
+ startRow = destination.getStartRow() == null ? null
+ : Base64.getUrlEncoder().encodeToString(destination.getStartRow());
+ endRow = destination.getEndRow() == null ? null
+ : Base64.getUrlEncoder().encodeToString(destination.getEndRow());
+ rangeType = destination.getRangeType();
+ }
+
+ Destination toDestination() {
+ return new Destination(fileName, rangeType,
+ startRow == null ? null : Base64.getUrlDecoder().decode(startRow),
+ endRow == null ? null : Base64.getUrlDecoder().decode(endRow));
+ }
+ }
+
+ private static final class JsonAll {
+ List<JsonDestination> destinations;
+
+ JsonAll() {}
+
+ JsonAll(List<Destination> destinations) {
+ this.destinations =
+
destinations.stream().map(JsonDestination::new).collect(Collectors.toList());
+ }
+
+ }
+
+ private static final Gson gson = new
GsonBuilder().disableJdkUnsafe().serializeNulls().create();
+
+ /**
+ * Serializes the load plan to json that looks like the following. The
values of startRow and
+ * endRow field are base64 encoded using {@link Base64#getUrlEncoder()}.
+ *
+ * <pre>
+ * {
+ * "destinations": [
+ * {
+ * "fileName": "f1.rf",
+ * "startRow": null,
+ * "endRow": "MDAz",
+ * "rangeType": "TABLE"
+ * },
+ * {
+ * "fileName": "f2.rf",
+ * "startRow": "MDA0",
+ * "endRow": "MDA3",
+ * "rangeType": "FILE"
+ * },
+ * {
+ * "fileName": "f1.rf",
+ * "startRow": "MDA1",
+ * "endRow": "MDA2",
+ * "rangeType": "TABLE"
+ * },
+ * {
+ * "fileName": "f3.rf",
+ * "startRow": "MDA4",
+ * "endRow": null,
+ * "rangeType": "TABLE"
+ * }
+ * ]
+ * }
+ * </pre>
+ *
+ * @since 2.1.4
+ */
+ public String toJson() {
+ return gson.toJson(new JsonAll(destinations));
+ }
+
+ /**
+ * Deserializes json to a load plan.
+ *
+ * @param json produced by {@link #toJson()}
+ */
+ public static LoadPlan fromJson(String json) {
+ var dests = gson.fromJson(json, JsonAll.class).destinations.stream()
+
.map(JsonDestination::toDestination).collect(Collectors.toUnmodifiableList());
+ return new LoadPlan(dests);
+ }
+
+ /**
+ * Represents two split points that exist in a table being bulk imported to.
+ *
+ * @since 2.1.4
+ */
+ public static class TableSplits {
+ private final Text prevRow;
+ private final Text endRow;
+
+ public TableSplits(Text prevRow, Text endRow) {
+ Preconditions.checkArgument(
+ prevRow == null || endRow == null || prevRow.compareTo(endRow) < 0,
"%s >= %s", prevRow,
+ endRow);
+ this.prevRow = prevRow;
+ this.endRow = endRow;
+ }
+
+ public Text getPrevRow() {
+ return prevRow;
+ }
+
+ public Text getEndRow() {
+ return endRow;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ TableSplits that = (TableSplits) o;
+ return Objects.equals(prevRow, that.prevRow) && Objects.equals(endRow,
that.endRow);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(prevRow, endRow);
+ }
+
+ @Override
+ public String toString() {
+ return "(" + prevRow + "," + endRow + "]";
+ }
+ }
+
+ /**
+ * A function that maps a row to two table split points that contain the
row. These splits must
+ * exist in the table being bulk imported to. There is no requirement that
the splits are
Review Comment:
Yeah, the javadoc should cover the null case. Made updates in 84142cd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
