dlmarion commented on code in PR #5256:
URL: https://github.com/apache/accumulo/pull/5256#discussion_r1928863828
##########
server/base/src/main/java/org/apache/accumulo/server/tables/TableManager.java:
##########
@@ -286,11 +285,13 @@ public void accept(WatchedEvent event) {
case NodeCreated:
case NodeDataChanged:
// state transition
- TableState tState = updateTableStateCache(tableId);
- log.debug("State transition to {} @ {}", tState, event);
- synchronized (observers) {
- for (TableObserver to : observers) {
- to.stateChanged(tableId, tState);
+ if (tableId != null) {
+ TableState tState = updateTableStateCache(tableId);
+ log.debug("State transition to {} @ {}", tState, event);
+ synchronized (observers) {
+ for (TableObserver to : observers) {
+ to.stateChanged(tableId, tState);
+ }
}
}
Review Comment:
tableId is only set in the code above this block when
`Constants.ZTABLE_STATE` is in the path. I had to add the tableId null check
because this Watcher started to get called for non-ZTABLE_STATE changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
