dlmarion commented on PR #5256: URL: https://github.com/apache/accumulo/pull/5256#issuecomment-2613278659
> > @keith-turner - I removed the calls to ZooKeeper.exists in [ae7ace8](https://github.com/apache/accumulo/commit/ae7ace8edda439e80a9b0da74fa7f0bdef2fd8e3). ZooCacheTest wasn't an easy fix, not sure it's 100% correct. It definitely needs some eyes on it. > > @dlmarion the changes to remove exists look good. I found some code that should be removed while looking at it. Re ZooCacheTest, was there a specifc method/part you wanted reviewed? There were a lot of changes there, and I had to make some assumptions based on removing exists calls. I also had to change ZcNode to allow `data` to be null. The documentation on some of the methods said that data could be null, but there was code in the class preventing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
