ctubbsii commented on PR #85: URL: https://github.com/apache/accumulo-access/pull/85#issuecomment-2657522341
@keith-turner are you sure this is a good idea? Changing it to begin with "IllegalAccess" makes it seem like it's related to https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/IllegalAccessException.html or https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/IllegalAccessError.html, which is not what this is. In this case, it's only an illegal argument because the access expression is invalid, so I think the previous name still makes sense. At the very least, the word "illegal" seems to imply "disallowed" but without a reason why. "Invalid", on the other hand, makes it clear that it's disallowed because it's not a valid access expression. Given the potential for confusion, and the loss of the clarity about validity/lack thereof, I think it's better to stick with the old name. I'm not sure there's a compelling reason to make the exception match the parent's name. Making it the same prefix just to make it the same isn't really compelling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
