ddanielr commented on PR #5358:
URL: https://github.com/apache/accumulo/pull/5358#issuecomment-2685455414

   > It would be good to also pull in the changes from Manager.balanceTablets() 
that removes the do/while loop. The loop duplicates code and holds up a thread 
in the manager that does other import stuff. By having the code just return 
from the function when the metadata is not balanced it avoids duplicating code 
and holding that thread.
   
   Pulled that change in as well. That should ensure that `updateStatus()` 
doesn't get stuck on `balanceTablets()`. 
   
   Ran the balanceIT test and checked the manager logs. 
   Confirmed that USER level balancing was being blocked due to metadata 
migrations as expected. 
   ```
   2025-02-26T15:25:33,918 [manager.Manager] DEBUG: Balancing for tables at 
level ROOT
    920 2025-02-26T15:25:33,919 [manager.Manager] DEBUG: Balancing for tables 
at level METADATA
    921 2025-02-26T15:25:33,919 [balancer.SimpleLoadBalancer] WARN : Not 
balancing due to 1 outstanding migrations.
    922 2025-02-26T15:25:33,920 [balancer.SimpleLoadBalancer] DEBUG: Sample up 
to 10 outstanding migrations: !0;2;1n
    923 2025-02-26T15:25:33,920 [manager.Manager] DEBUG: Not balancing USER 
because METADATA has migrations
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to