kevinrr888 commented on code in PR #5031:
URL: https://github.com/apache/accumulo/pull/5031#discussion_r1972260495
##########
core/src/main/java/org/apache/accumulo/core/fate/user/UserFateStore.java:
##########
@@ -48,6 +48,7 @@
import org.apache.accumulo.core.fate.ReadOnlyRepo;
import org.apache.accumulo.core.fate.Repo;
import org.apache.accumulo.core.fate.StackOverflowException;
+import org.apache.accumulo.core.fate.user.schema.FateSchema;
import org.apache.accumulo.core.fate.user.schema.FateSchema.RepoColumnFamily;
import org.apache.accumulo.core.fate.user.schema.FateSchema.TxColumnFamily;
import org.apache.accumulo.core.fate.user.schema.FateSchema.TxInfoColumnFamily;
Review Comment:
For consistency, would be nicer to just import
FateSchema.TxAdminColumnFamily and just use TxAdminColumnFamily throughout this
class
##########
core/src/main/java/org/apache/accumulo/core/fate/user/FateMutatorImpl.java:
##########
@@ -43,6 +43,7 @@
import org.apache.accumulo.core.fate.FateStore;
import org.apache.accumulo.core.fate.ReadOnlyFateStore.TStatus;
import org.apache.accumulo.core.fate.Repo;
+import org.apache.accumulo.core.fate.user.schema.FateSchema;
import org.apache.accumulo.core.fate.user.schema.FateSchema.RepoColumnFamily;
import org.apache.accumulo.core.fate.user.schema.FateSchema.TxColumnFamily;
import org.apache.accumulo.core.fate.user.schema.FateSchema.TxInfoColumnFamily;
Review Comment:
Same thing here with importing FateSchema.TxAdminColumnFamily and using
TxAdminColumnFamily throughout this class
##########
server/base/src/main/java/org/apache/accumulo/server/init/InitialConfiguration.java:
##########
@@ -88,11 +88,14 @@ public InitialConfiguration(Configuration hadoopConf,
SiteConfiguration siteConf
initialFateTableConf.putAll(commonConfig);
initialFateTableConf.put(Property.TABLE_SPLIT_THRESHOLD.getKey(), "256M");
- // Create a locality group that contains status so its fast to scan. When
fate looks for work is
- // scans this family.
+ // Create a locality group that contains status and reservation so its
fast to scan. When fate
+ // looks for work is scans this family.
initialFateTableConf.put(Property.TABLE_LOCALITY_GROUP_PREFIX.getKey() +
"status",
FateSchema.TxColumnFamily.STR_NAME);
- initialFateTableConf.put(Property.TABLE_LOCALITY_GROUPS.getKey(),
"status");
+
+ initialFateTableConf.put(Property.TABLE_LOCALITY_GROUP_PREFIX.getKey() +
"statusReservation",
+ FateSchema.TxAdminColumnFamily.STR_NAME);
+ initialFateTableConf.put(Property.TABLE_LOCALITY_GROUPS.getKey(),
"statusReservation");
Review Comment:
Instead of `statusReservation` would be better as `txadmin` or something
similar. When https://github.com/apache/accumulo/pull/5301 is merged, the
`FateOp` column is going to need to be added to the same locality group (see
the changes to `UserFateStore` if curious), so `statusReservation` will no
longer be applicable.
##########
server/base/src/main/java/org/apache/accumulo/server/init/InitialConfiguration.java:
##########
@@ -88,11 +88,14 @@ public InitialConfiguration(Configuration hadoopConf,
SiteConfiguration siteConf
initialFateTableConf.putAll(commonConfig);
initialFateTableConf.put(Property.TABLE_SPLIT_THRESHOLD.getKey(), "256M");
- // Create a locality group that contains status so its fast to scan. When
fate looks for work is
- // scans this family.
+ // Create a locality group that contains status and reservation so its
fast to scan. When fate
+ // looks for work is scans this family.
initialFateTableConf.put(Property.TABLE_LOCALITY_GROUP_PREFIX.getKey() +
"status",
FateSchema.TxColumnFamily.STR_NAME);
- initialFateTableConf.put(Property.TABLE_LOCALITY_GROUPS.getKey(),
"status");
+
+ initialFateTableConf.put(Property.TABLE_LOCALITY_GROUP_PREFIX.getKey() +
"statusReservation",
+ FateSchema.TxAdminColumnFamily.STR_NAME);
+ initialFateTableConf.put(Property.TABLE_LOCALITY_GROUPS.getKey(),
"statusReservation");
Review Comment:
```
initialFateTableConf.put(Property.TABLE_LOCALITY_GROUP_PREFIX.getKey() +
"status",
FateSchema.TxColumnFamily.STR_NAME);
```
This can be deleted this isn't needed anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
