keith-turner commented on PR #5384: URL: https://github.com/apache/accumulo/pull/5384#issuecomment-2706617371
> LGTM, while reviewing this I noticed the encrypter is also storing those the cipher as a private member variable [here](https://github.com/apache/accumulo/blob/5b9264ca37c7d56f4e8f76687f028a845db96277/core/src/main/java/org/apache/accumulo/core/spi/crypto/AESCryptoService.java#L357) and [here](https://github.com/apache/accumulo/blob/5b9264ca37c7d56f4e8f76687f028a845db96277/core/src/main/java/org/apache/accumulo/core/spi/crypto/AESCryptoService.java#L499). > I haven't taken a closer look but can the encrypter also be shared between multiple threads? If so then I think the same fix is needed there. I do not think compactions would ever have multiple threads writing. WAL writes may have multiple threads writing, not sure need to investigate. I tried to create multithreaded unit test for the write case and was having problems getting that test working so did not change the write code. Will open a follow on issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
