keith-turner commented on code in PR #5396:
URL: https://github.com/apache/accumulo/pull/5396#discussion_r1989974973
##########
assemble/bin/accumulo-cluster:
##########
@@ -485,6 +485,26 @@ function control_services() {
if [[ $ARG_ALL == 1 && $ARG_LOCAL == 0 && $operation == "stop" ]]; then
echo "Stopping Accumulo cluster..."
if ! isDebug; then
+ # Stop all of the the Scan Server processes
Review Comment:
> The code below is also used for starting or stopping just the gc or
sserver processes, and for starting everything.
That clue was very helpful in understanding the bigger picture. Did not
realize this function did start and stop.
Compared this new code to the existing code and it looks good. Noticed the
local var may be declared twice in the same function, not sure if bash cares
about that though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
