Re: [PR] implements interuption of compactions and adds an IT to verify compaction cancels on tablet migration [accumulo]

[via GitHub]

dlmarion commented on PR #5395:
URL: https://github.com/apache/accumulo/pull/5395#issuecomment-2717806423

   I'm wondering if we should change:
   
   
https://github.com/apache/accumulo/blob/29506999476e99ffc15019469c35705ced0d3278/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java#L1199-L1201
   
   to:
   
   ```
       public boolean isCompactionEnabled() {
         return !Thread.currentThread.isInterrupted() && inexpensiveCheck.get() 
&& expensiveCheck.get();
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org