ctubbsii commented on PR #5421: URL: https://github.com/apache/accumulo/pull/5421#issuecomment-2738513521
I think there is still more cleanup needed in the location cache code, even if this is a start. I'm wondering if one big location cache (still separate obtainers based on tableId) is better than having hierarchical caches that are tightly coupled to their obtainers. Even if we don't do that, I think some of the naming and APIs could be cleaned up and I'm a bit concerned about the way the ZookeeperLockChecker is used by these, and has its own ZooSession/ZooCache. It can probably use the context's own ZooSession/ZooCache now, but I'm not quite sure, since these obtainers may still spin off background threads that outlive the context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
