ctubbsii commented on code in PR #5420:
URL: https://github.com/apache/accumulo/pull/5420#discussion_r2006545777
##########
server/base/src/main/java/org/apache/accumulo/server/tables/TableManager.java:
##########
@@ -57,29 +57,37 @@
public class TableManager {
private static final Logger log =
LoggerFactory.getLogger(TableManager.class);
- private static final Set<TableObserver> observers =
Collections.synchronizedSet(new HashSet<>());
- private static final Map<TableId,TableState> tableStateCache =
- Collections.synchronizedMap(new HashMap<>());
private static final byte[] ZERO_BYTE = {'0'};
+ private final Set<TableObserver> observers = Collections.synchronizedSet(new
HashSet<>());
+ private final Map<TableId,TableState> tableStateCache =
Review Comment:
@dlmarion I made an attempt at this in #5422 if you want to take a look. I
think the code is cleaner, but there is a downside with deserializing the state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
