keith-turner commented on code in PR #5383:
URL: https://github.com/apache/accumulo/pull/5383#discussion_r2031805129
##########
server/base/src/main/java/org/apache/accumulo/server/util/UpgradeUtil.java:
##########
@@ -48,6 +59,14 @@ static class Opts extends ConfigOpts {
description = "prepare an older version instance for an upgrade to a
newer non-bugfix release."
+ " This command should be run using the older version of software
after the instance is shut down.")
boolean prepare = false;
+
+ @Parameter(names = "--check",
+ description = "check that 'accumulo upgrade --prepare' was run on the
instance after it was shut down.")
+ boolean check = false;
Review Comment:
This is naming suggesting, feel free to ignore.
This seems to do more than check if the 2.1. step was run, it also makes
changes that allow the 4.0 upgrade to run. I think of check as passive and
looking at they state of things and not changing anything. Could possibly use
another name that implies something more active is happening.
```suggestion
@Parameter(names = "--initiate",
description = "check that 'accumulo upgrade --prepare' was run on
the instance after it was shut down and sets persistent markers that allow the
manager to run upgrade steps when it next starts.")
boolean check = false;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
