keith-turner commented on PR #5380:
URL: https://github.com/apache/accumulo/pull/5380#issuecomment-2784419820
This unit test is not testing the metadata cleanup related to dead
compactions. Would be better to do this in an IT, would be difficult to test
the metadata updates in a unit test. Could do something like the following in
an IT.
1. Start 6 ExternalDoNothingCompactor processes
2. Create a table w/ 3 tablets
3. Limit compactions to 10 files per compaction
4. Configure table to use the 6 ExternalDoNothingCompactor
5. write 30 files to first tablet, want this to start 3 compactions for the
tablet
6. write 20 files to 2nd tablet, want this to start 2 compactions for the
tablet
7. write 10 files to 3rd tablet, want this to start 1 compaction for the
tablet
8. Continually read metadata table looking for the 6 compactions, when
found remember their unique ids
9. Kill the 6 ExternalDoNothingCompactor
10. Continually read metadata table waiting for the 6 compaction ids to
disappear (the compaction coordinator should detect the processes died and
clean up any per tablet compaction entries).
11. Read the running set from the coordinator until the 6 ids are gone
This test would cover what this test is attempting to cover and more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
