keith-turner commented on code in PR #5460:
URL: https://github.com/apache/accumulo/pull/5460#discussion_r2037772437
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -504,12 +504,15 @@ static long loadFiles(Loader loader, BulkInfo bulkInfo,
Path bulkDir,
}
long sleepTime = loader.finish();
- if (sleepTime > 0) {
- log.trace("{}: Tablet Max Sleep is {}", fmtTid, sleepTime);
- long scanTime = Math.min(totalProcessingTime.toMillis(), 30_000);
- log.trace("{}: Scan time is {}", fmtTid, scanTime);
- sleepTime = Math.max(sleepTime, scanTime * 2);
+ if (sleepTime <= 1) {
+ log.trace("{}: Sleeping for {}ms", fmtTid, sleepTime);
+ return sleepTime;
}
+
+ log.trace("{}: Tablet Max Sleep is {}", fmtTid, sleepTime);
+ long scanTime = Math.min(totalProcessingTime.toMillis(), 30_000);
+ log.trace("{}: Scan time is {}", fmtTid, scanTime);
+ sleepTime = Math.max(sleepTime, scanTime * 2);
Review Comment:
@ctubbsii in your suggestions could change the comment to... 1 does not
indicate success in that this step is done, it means its probably done but need
to run this step again and scan metadata table again to be sure.
```java
// sleepTime of 0 indicates success. sleepTime of 1 indicates all rpcs to
tservers are done, and we are probably done but still need to run this step
agains and scan metadata table one more time to be sure.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
