keith-turner commented on code in PR #5472:
URL: https://github.com/apache/accumulo/pull/5472#discussion_r2040214337
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchWriter.java:
##########
@@ -210,8 +210,7 @@ public long getTimeOut() {
public TabletServerBatchWriter(ClientContext context, BatchWriterConfig
config) {
this.context = context;
- this.executor = context.threadPools()
-
.createGeneralScheduledExecutorService(this.context.getConfiguration());
+ this.executor = context.getScheduledExecutor();
Review Comment:
This change makes me a bit uneasy, but maybe its ok. Just thinking of the
case of batch writers for the metadata table and root table using this shared
thread pool and root table failure not being able to process because a metadata
table task is stuck. Not sure if this can actually happen w/ this code though,
if it does though it could casue problems for manager or tablets servers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
