kevinrr888 opened a new pull request, #5474: URL: https://github.com/apache/accumulo/pull/5474
This PR: Creates a comprehensive IT of all table operations against both system and user tables while trying to avoid duplicating existing testing. For example, when there was more extensive testing of a table operation elsewhere, these new tests just ensure that that testing still exists. This IT does not test for edge cases, but rather tests for basic expected functionality of all table operations against user tables and all system tables (ROOT, METADATA, FATE, SCAN_REF). Motivation: - No single test testing all table operations making it hard to know what is or isn't tested - Lots of operations that aren't tested on all system tables and some operations that are completely untested. Good to ensure each table op works as expected on the different system tables as well as user tables. For example, some ops can't be performed on the metadata tables (ROOT, METADATA) but can be performed on FATE and SCAN_REF, some ops aren't allowed on any system tables, etc. - Has made identifying potential issues related to what ops are allowed on what system tables easier. For example, have discovered that `offline`ing the FATE and SCAN_REF tables are allowed through the table operations API when they shouldn't be (#5433) - Ensures end-to-end functionality of table operations always work as expected - Ensures FATE, as it's used in the Manager, is functioning as expected for both META (FATE ops against system tables) and USER (FATE ops against user tables) FATE ops. This is important since they use different resources and different stores. Lots of individual FATE tests, but this verifies FATE is working as expected in the Manager. - Will force any newly added table operations to have testing here. - Will force any new system tables to be considered in these tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
