DomGarguilo commented on code in PR #5398:
URL: https://github.com/apache/accumulo/pull/5398#discussion_r2045393584
##########
core/src/main/java/org/apache/accumulo/core/trace/TraceUtil.java:
##########
@@ -191,22 +194,13 @@ public static <T> Callable<T> unwrap(Callable<T> c) {
public static <T> T wrapService(final T instance) {
InvocationHandler handler = (obj, method, args) -> {
- if (args == null || args.length < 1 || args[0] == null || !(args[0]
instanceof TInfo)) {
- try {
- return method.invoke(instance, args);
- } catch (InvocationTargetException e) {
- throw e.getCause();
- }
- }
- Span span = startServerRpcSpan(instance.getClass(), method.getName(),
(TInfo) args[0]);
- try (Scope scope = span.makeCurrent()) {
+ Span span = Span.current(); // should be set by protocol
+ try {
Review Comment:
Okay I think I fixed this in 8d742ea. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
