keith-turner commented on code in PR #5289:
URL: https://github.com/apache/accumulo/pull/5289#discussion_r2049328976


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -585,15 +583,17 @@ private MinorCompactionTask 
createMinorCompactionTask(long flushId,
       MinorCompactionReason mincReason) {
     MinorCompactionTask mct;
     long t1, t2;
-
+    long pauseLimit =
+        
getContext().getTableConfiguration(extent.tableId()).getCount(Property.TABLE_FILE_PAUSE);
     StringBuilder logMessage = null;
 
     try {
       synchronized (this) {
         t1 = System.currentTimeMillis();
 
         if (isClosing() || isClosed() || 
getTabletMemory().memoryReservedForMinC()
-            || getTabletMemory().getMemTable().getNumEntries() == 0 || 
updatingFlushID) {

Review Comment:
   Should not remove the ` getTabletMemory().getMemTable().getNumEntries() == 
0` check.  We do not want to bother initiating a minor compaction for a tablet 
that has not key/values in memory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to